linux-kernel - Re: [PATCH v11 2/4] PCI: designware: Add generic dw_pcie_wait_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 26 Feb 2016 22:54:52 +0530
From:	Pratyush Anand <pratyush.anand@...il.com>
To:	Bjorn Helgaas <bhelgaas@...gle.com>
Cc:	Joao Pinto <Joao.Pinto@...opsys.com>,
	Mark Rutland <mark.rutland@....com>,
	Alexey.Brodkin@...opsys.com, Arnd Bergmann <arnd@...db.de>,
	Pawel Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	Vineet.Gupta1@...opsys.com, linux-kernel@...r.kernel.org,
	Carlos Palminha <CARLOS.PALMINHA@...opsys.com>,
	Rob Herring <robh+dt@...nel.org>,
	Murali Karicheri <m-karicheri2@...com>,
	Kumar Gala <galak@...eaurora.org>,
	Jingoo Han <jingoohan1@...il.com>,
	linux-snps-arc@...ts.infradead.org
Subject: Re: [PATCH v11 2/4] PCI: designware: Add generic dw_pcie_wait_for_link()

On Fri, Feb 26, 2016 at 10:00 PM, Bjorn Helgaas <bhelgaas@...gle.com> wrote:
> From: Joao Pinto <Joao.Pinto@...opsys.com>
>
> Several DesignWare-based drivers (dra7xx, exynos, imx6, keystone, qcom, and
> spear13xx) had similar loops waiting for the link to come up.
>
> Add a generic dw_pcie_wait_for_link() for use by all these drivers so the
> waiting is done consistently, e.g., always using usleep_range() rather than
> mdelay() and using similar timeouts and retry counts.
>
> Note that this changes the Keystone link training/wait for link strategy,
> so we initiate link training, then wait longer for the link to come up
> before re-initiating link training.
>
> [bhelgaas: changelog, split into its own patch, update pci-keystone.c, pcie-qcom.c]
> Signed-off-by: Joao Pinto <jpinto@...opsys.com>
> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>

5 retries should be sufficient for keystone, still it would be good to
have a tested-by for it.
Other than that code seems fine to me.

Acked-by: Pratyush Anand <pratyush.anand@...il.com>