linux-kernel - Re: [PATCH v2 0/8] mtd: spi-nor: locking fixes and updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 26 Feb 2016 23:04:53 -0300
From:	Ezequiel Garcia <ezequiel@...guardiasur.com.ar>
To:	Brian Norris <computersforpeace@...il.com>
Cc:	linux-mtd@...ts.infradead.org,
	Rafał Miłecki <zajec5@...il.com>,
	Boris Brezillon <boris.brezillon@...e-electrons.com>,
	linux-kernel@...r.kernel.org, Bayi Cheng <bayi.cheng@...iatek.com>,
	Marek Vasut <marex@...x.de>, djkurtz@...omium.org
Subject: Re: [PATCH v2 0/8] mtd: spi-nor: locking fixes and updates

On 29 Jan 11:25 AM, Brian Norris wrote:
> Hi,
> 
> These are an assortment of fixes and updates to the SPI NOR lock/unlock
> feature. The biggest new features are:
> (a) Status Register protection; I don't see why this shouldn't be enabled by
>     default. See patch 4's description.
> (b) Bottom-block protection support (via TB status bit)
> (c) Lock/unlock support for a few Winbond flash
> 
> Since v1:
>  * patches 3 and 7 are somewhat rewritten versions of patches 2 and 7 in v1
>  * fix up several corner cases, seen in some local tests (poor, slow shell
>    script appended)
>  * remove SR protection (SR_SRWD) when unlocking the entire flash
> 
> Regards,
> Brian
> 
> Brian Norris (8):
>   mtd: spi-nor: wait for SR_WIP to clear on initial unlock
>   mtd: spi-nor: silently drop lock/unlock for already locked/unlocked
>     region
>   mtd: spi-nor: make lock/unlock bounds checks more obvious and robust
>   mtd: spi-nor: disallow further writes to SR if WP# is low
>   mtd: spi-nor: use BIT() for flash_info flags
>   mtd: spi-nor: add SPI_NOR_HAS_LOCK flag
>   mtd: spi-nor: add TB (Top/Bottom) protect support
>   mtd: spi-nor: support lock/unlock for a few Winbond chips
> 
>  drivers/mtd/spi-nor/spi-nor.c | 195 ++++++++++++++++++++++++++++++++++--------
>  include/linux/mtd/spi-nor.h   |   2 +
>  2 files changed, 159 insertions(+), 38 deletions(-)
> 
> 
> Appending badly-written shell test script. Requires latest mtd-utils
> (flash_lock / flash_unlock).
> 

Thanks for the cool script. I've tested it on Armada XP GP board,
which has a n25q128a13 flash. Tests passed, the results are
attached.

Tested-by: Ezequiel Garcia <ezequiel@...guardiasur.com.ar>
-- 
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar

View attachment "spi-nor-locktest" of type "text/plain" (8895 bytes)