linux-kernel - Re: [PATCH] configfs: switch ->default groups to a linked list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 28 Feb 2016 12:58:42 +0200
From:	Sagi Grimberg <sagig@....mellanox.co.il>
To:	Christoph Hellwig <hch@....de>, jlbec@...lplan.org
Cc:	balbi@...nel.org, laurent.pinchart@...asonboard.com,
	target-devel@...r.kernel.org, linux-usb@...r.kernel.org,
	linux-rdma@...r.kernel.org, cluster-devel@...hat.com,
	ocfs2-devel@....oracle.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] configfs: switch ->default groups to a linked list



On 26/02/2016 14:33, Christoph Hellwig wrote:
> Replace the current NULL-terminated array of default groups with a linked
> list.  This gets rid of lots of nasty code to size and/or dynamically
> allocate the array.
>
> While we're at it also provide a conveniant helper to remove the default
> groups.
>
> Signed-off-by: Christoph Hellwig <hch@....de>
> ---

Nice!

> -As a consequence of this, default_groups cannot be removed directly via
> +As a consequence of this, default groups cannot be removed directly via
>   rmdir(2).  They also are not considered when rmdir(2) on the parent
>   group is checking for children.
>

What's changed here?

Other than that, looks good

Reviewed-by: Sagi Grimberg <sagig@...lanox.com>