linux-kernel - Re: [tip:smp/hotplug] cpu/hotplug: Make target state writeable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 2 Mar 2016 20:57:19 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Peter Zijlstra <peterz@...radead.org>
cc:	rostedt@...dmis.org, riel@...hat.com, mingo@...nel.org,
	rafael.j.wysocki@...el.com, bigeasy@...utronix.de,
	arjan@...ux.intel.com, rusty@...tcorp.com.au,
	torvalds@...ux-foundation.org, hpa@...or.com, srivatsa@....edu,
	pjt@...gle.com, tj@...nel.org, akpm@...ux-foundation.org,
	oleg@...hat.com, linux-kernel@...r.kernel.org,
	paulmck@...ux.vnet.ibm.com, linux-tip-commits@...r.kernel.org
Subject: Re: [tip:smp/hotplug] cpu/hotplug: Make target state writeable

On Wed, 2 Mar 2016, Peter Zijlstra wrote:
> On Tue, Mar 01, 2016 at 11:55:01AM -0800, tip-bot for Thomas Gleixner wrote:
> > Commit-ID:  757c989b9994f51b42d6be1bd33c7c12d16a3ac7
> > Gitweb:     http://git.kernel.org/tip/757c989b9994f51b42d6be1bd33c7c12d16a3ac7
> > Author:     Thomas Gleixner <tglx@...utronix.de>
> > AuthorDate: Fri, 26 Feb 2016 18:43:32 +0000
> > Committer:  Thomas Gleixner <tglx@...utronix.de>
> > CommitDate: Tue, 1 Mar 2016 20:36:55 +0100
> > 
> > cpu/hotplug: Make target state writeable
> > 
> > Make it possible to write a target state to the per cpu state file, so we can
> > switch between states.
> 
> But you've marked nearly all of them cant_stop, so while this implements
> the interface, its not really functional just yet, right?

Yes, the current state is more or less wrapping the existing notifiers and
stopping them is not a brilliant idea. I've tried and it exploded nicely in my
face. The ones we convert over to the state machine will be stoppable and
reversible. And at the end the notifiers will be gone and with them the can't
stop stuff, except maybe for a few crucial points.

Thanks,

	tglx