linux-kernel - Re: [PATCH] pcmcia: db1xxx: use correct irq_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 2 Mar 2016 07:50:28 +0100
From:	Manuel Lauss <manuel.lauss@...il.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Ralf Baechle <ralf@...ux-mips.org>,
	linux-pcmcia <linux-pcmcia@...ts.infradead.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Linux-MIPS <linux-mips@...ux-mips.org>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] pcmcia: db1xxx: use correct irq_to_gpio helper

 Hi Arnd,


On Tue, Mar 1, 2016 at 11:12 PM, Arnd Bergmann <arnd@...db.de> wrote:
> After the removal of asm/gpio.h and asm/mach-au1x00/gpio.h, the db1xxx_ss
> pcmcia driver picked up the wrong irq_to_gpio function from the generic
> headers.
>
> This restores the old __au_irq_to_gpio() implementation, but keeps
> it local to the only file that uses it.
>
> It would be nicer to just pass the gpio number from platform code,
> but restoring the previous implementation seems safer.

Give me a few hours and I'll fix this driver for good.


> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Cc: stable@...r.kernel.org # v4.3
> Fixes: 832f5dacfa0b ("MIPS: Remove all the uses of custom gpio.h")
> ---
> I think this is now the last holdout of the irq_to_gpio function,
> and it's been broken for a while. Maybe Ralf can queue it up through
> the MIPS tree along with the other fix for irq_to_gpio?

It's not broken though..  this driver on current linus-git works fine!

Thank you,
      Manuel