linux-kernel - Re: [abelloni:rtc-testing 55/55] drivers/rtc/rtc-pcf85063.c:72:19: warning: unused variable 'pcf85063'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 2 Mar 2016 11:26:34 +0100
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Juergen Borleis <jbe@...gutronix.de>
Cc:	kbuild test robot <fengguang.wu@...el.com>,
	rtc-linux@...glegroups.com,
	Alessandro Zummo <a.zummo@...ertech.it>,
	linux-kernel@...r.kernel.org
Subject: Re: [abelloni:rtc-testing 55/55] drivers/rtc/rtc-pcf85063.c:72:19:
 warning: unused variable 'pcf85063'

Hi,

On 02/03/2016 at 10:44:29 +0100, Juergen Borleis wrote :
> Hi Alexandre,
> 
> On Tuesday 01 March 2016 23:17:45 kbuild test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git
> > rtc-testing head:   58992ebde059d7faeab4c18bc17713c3b4c31208
> > commit: 58992ebde059d7faeab4c18bc17713c3b4c31208 [55/55] rtc: pcf85063:
> > remove useless century handling config: x86_64-randconfig-x012-201609
> > (attached as .config)
> > reproduce:
> >         git checkout 58992ebde059d7faeab4c18bc17713c3b4c31208
> >         # save the attached .config to linux build tree
> >         make ARCH=x86_64
> >
> > All warnings (new ones prefixed by >>):
> >
> >    drivers/rtc/rtc-pcf85063.c: In function 'pcf85063_get_datetime':
> > >> drivers/rtc/rtc-pcf85063.c:72:19: warning: unused variable 'pcf85063'
> > >> [-Wunused-variable]
> >
> >      struct pcf85063 *pcf85063 = i2c_get_clientdata(client);
> >                       ^
> 
> Due to your removement of the useless century handling the last user of 'struct 
> pcf85063' is gone. Seems we can remove this struct entirely. What do you 
> think?
> 

Sure, that was also my reasoning when fixing that warning. I've sent
follow up patches.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com