linux-kernel - Re: [PATCH] ovl: fix working on distributed fs as lower layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 2 Mar 2016 15:18:58 +0100
From:	Miklos Szeredi <miklos@...redi.hu>
To:	Nikolay Borisov <kernel@...p.com>
Cc:	Konstantin Khlebnikov <koct9i@...il.com>,
	Linux-Fsdevel <linux-fsdevel@...r.kernel.org>,
	"linux-unionfs@...r.kernel.org" <linux-unionfs@...r.kernel.org>,
	Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Alexander Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH] ovl: fix working on distributed fs as lower layer

On Thu, Feb 18, 2016 at 8:56 AM, Nikolay Borisov <kernel@...p.com> wrote:
>
>
> On 01/31/2016 03:22 PM, Konstantin Khlebnikov wrote:
>> This adds missing .d_select_inode into alternative dentry_operations.
>>
>> Signed-off-by: Konstantin Khlebnikov <koct9i@...il.com>
>> Fixes: 7c03b5d45b8e ("ovl: allow distributed fs as lower layer")
>> Fixes: 4bacc9c9234c ("overlayfs: Make f_path always point to the overlay and f_inode to the underlay")
>> ---
>>  fs/overlayfs/super.c |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
>> index e6ae59c7119c..1a354840f262 100644
>> --- a/fs/overlayfs/super.c
>> +++ b/fs/overlayfs/super.c
>> @@ -343,6 +343,7 @@ static const struct dentry_operations ovl_dentry_operations = {
>>
>>  static const struct dentry_operations ovl_reval_dentry_operations = {
>>       .d_release = ovl_dentry_release,
>> +     .d_select_inode = ovl_d_select_inode,
>>       .d_revalidate = ovl_dentry_revalidate,
>>       .d_weak_revalidate = ovl_dentry_weak_revalidate,
>>  };
>
> I wish I had seen this patch earlier than
> https://marc.info/?l=linux-unionfs&m=145494313009959
>
>
> Reviewed-by: Nikolay Borisov <kernel@...p.com>
> Tested-by: Nikolay Borisov <kernel@...p.com>
>

Thanks for the patch, queued.

Miklos