[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Thu, 3 Mar 2016 16:53:23 -0600
From: Rob Herring <robh@...nel.org>
To: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Cc: Frank Rowand <frowand.list@...il.com>,
Grant Likely <grant.likely@...aro.org>,
Petr Mladek <pmladek@...e.com>,
Andrew Morton <akpm@...ux-foundation.org>,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Subject: Re: [PATCH] of/unittest: fix infinite loop in
of_unittest_destroy_tracked_overlays()
On Wed, Mar 02, 2016 at 08:24:49PM +0900, Sergey Senozhatsky wrote:
> of_overlay_destroy() can return `-ENODEV' error code once it
> failed to find the requested overlay in `ov_idr'. However,
> of_unittest_destroy_tracked_overlays() does not handle this
> error code correctly and continues to call of_overlay_destroy()
> on the 'missing' overlay over and over again. This results in
> a printk flood
>
> [..]
> [ 33.497583] of_overlay_destroy: Could not find overlay #6
> [ 33.497583] of_overlay_destroy: Could not find overlay #6
> [ 33.497584] ### dt-test ### of_unittest_destroy_tracked_overlays: overlay destroy failed for #6
> [ 33.497584] ### dt-test ### of_unittest_destroy_tracked_overlays: overlay destroy failed for #6
> [ 33.497586] of_overlay_destroy: Could not find overlay #6
> [ 33.497586] of_overlay_destroy: Could not find overlay #6
> [ 33.497587] ### dt-test ### of_unittest_destroy_tracked_overlays: overlay destroy failed for #6
> [ 33.497587] ### dt-test ### of_unittest_destroy_tracked_overlays: overlay destroy failed for #6
> [..]
>
> which is not really good due to printk design, and can lead to soft
> lockups, hard lockups, etc. (depending on the context console_unlock()
> is being called from). The problem has bee observed in real life
> and reported by Ying Huang.
>
> This patch does not address the root cause of missing overlay in
> `ov_idr', it fixes the endless loop only.
>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> Reported-by: kernel test robot <ying.huang@...ux.intel.com>
> Link: lkml.kernel.org/r/87fuwk1c0o.fsf@...ang-dev.intel.com
> ---
> drivers/of/unittest.c | 5 +++++
> 1 file changed, 5 insertions(+)
Applied, thanks.
Rob
Powered by blists - more mailing lists