linux-kernel - Re: [PATCH v2 3/6] rockchip: power-domain: add support for sub-power domains

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 2 Mar 2016 16:05:15 -0800
From:	Kevin Hilman <khilman@...libre.com>
To:	Heiko Stuebner <heiko@...ech.de>
Cc:	Elaine Zhang <zhangqing@...k-chips.com>, wxt@...k-chips.com,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	huangtao@...k-chips.com, zyw@...k-chips.com, xxx@...k-chips.com,
	jay.xu@...k-chips.com, linux-rockchip@...ts.infradead.org,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 3/6] rockchip: power-domain: add support for sub-power domains

On Thu, Feb 18, 2016 at 4:20 PM, Heiko Stuebner <heiko@...ech.de> wrote:

> In general the code looks like you're going to group the domains
> hirarchically, like
>
>        power: power-controller {
>                compatible = "rockchip,rk3399-power-controller";
>
>                pd_cci {
>                        reg = <RK3399_PD_CCI>;
>                        clocks = ...;
>
>                         pd_cci0 {
>                                 reg = <RK3399_PD_CCI0>;
>                                 clocks = ...;
>                         };
>                };
>        };
>
> This isn't documented in the dt-binding and also isn't really improving
> reading these declarations. Instead as I said before, I think I'd like more
> get inspiration from how Exynos is doing that already

Heiko and I had a chat offline about this, and I mentioned that the
Exynos way is not the preferred way.  The nesting that is being done
here (and in v4) is the better way, and is fully supported by the
genpd code.

Kevin