linux-kernel - Re: [PATCH 2/2] rtc: pcf85063: remove struct pcf85063

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 3 Mar 2016 16:14:08 +0100
From:	Juergen Borleis <jbe@...gutronix.de>
To:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Cc:	rtc-linux@...glegroups.com,
	Alessandro Zummo <a.zummo@...ertech.it>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] rtc: pcf85063: remove struct pcf85063

On Wednesday 02 March 2016 11:25:43 Alexandre Belloni wrote:
> No members of struct pcf85063 are used anymore, remove the whole structure.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>
> ---
>  drivers/rtc/rtc-pcf85063.c | 22 +++++-----------------
>  1 file changed, 5 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/rtc/rtc-pcf85063.c b/drivers/rtc/rtc-pcf85063.c
> index 550f67518c5a..e8ddbb359d11 100644
> --- a/drivers/rtc/rtc-pcf85063.c
> +++ b/drivers/rtc/rtc-pcf85063.c
> @@ -31,11 +31,6 @@
>
>  static struct i2c_driver pcf85063_driver;
>
> -struct pcf85063 {
> -	struct rtc_device *rtc;
> -	int voltage_low; /* indicates if a low_voltage was detected */
> -};
> -
>  static int pcf85063_stop_clock(struct i2c_client *client, u8 *ctrl1)
>  {
>  	s32 ret;
> @@ -168,25 +163,18 @@ static const struct rtc_class_ops pcf85063_rtc_ops = {
>  static int pcf85063_probe(struct i2c_client *client, 
>  				const struct i2c_device_id *id)
>  {
> -	struct pcf85063 *pcf85063;
> +	struct rtc_device *rtc;
>
>  	dev_dbg(&client->dev, "%s\n", __func__);
>
>  	if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C))
>  		return -ENODEV;
>
> -	pcf85063 = devm_kzalloc(&client->dev, sizeof(struct pcf85063),
> -				GFP_KERNEL);
> -	if (!pcf85063)
> -		return -ENOMEM;
> -
> -	i2c_set_clientdata(client, pcf85063);
> -
> -	pcf85063->rtc = devm_rtc_device_register(&client->dev,
> -				pcf85063_driver.driver.name,
> -				&pcf85063_rtc_ops, THIS_MODULE);
> +	rtc = devm_rtc_device_register(&client->dev,
> +				       pcf85063_driver.driver.name,
> +				       &pcf85063_rtc_ops, THIS_MODULE);
>
> -	return PTR_ERR_OR_ZERO(pcf85063->rtc);
> +	return PTR_ERR_OR_ZERO(rtc);
>  }
>
>  static const struct i2c_device_id pcf85063_id[] = {

Reviewed-by: Juergen Borleis <jbe@...gutronix.de>

jb