linux-kernel - Re: [PATCH] perf tools: explicitly declare inc_group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 3 Mar 2016 16:59:29 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Colin King <colin.king@...onical.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...nel.org>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>, Wang Nan <wangnan0@...wei.com>,
	He Kuang <hekuang@...wei.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf tools: explicitly declare inc_group_count as a void
 function

Em Thu, Mar 03, 2016 at 01:39:39PM +0100, Jiri Olsa escreveu:
> On Thu, Mar 03, 2016 at 12:30:14PM +0000, Colin King wrote:
> > From: Colin Ian King <colin.king@...onical.com>
> > 
> > The return type is not defined, so it defaults to int, however,
> > the function is not returning anything, so this is clearly not
> > correct. Make it a void function.
> 
> Acked-by: Jiri Olsa <jolsa@...nel.org>

Thanks, applied.