linux-kernel - Re: [PATCH v4 4/7] Documentation: fsl-quadspi: Add fsl,ls2080a-dspi compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 7 Mar 2016 12:32:00 -0800
From:	Brian Norris <computersforpeace@...il.com>
To:	Yuan Yao <yao.yuan@...escale.com>
Cc:	dwmw2@...radead.org, han.xu@...escale.com, robh@...nel.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	linux-mtd@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org, yao.yuan@....com
Subject: Re: [PATCH v4 4/7] Documentation: fsl-quadspi: Add fsl,ls2080a-dspi
 compatible string

On Tue, Jan 26, 2016 at 03:23:58PM +0800, Yuan Yao wrote:
> new compatible string: "fsl,ls2080a-qspi".

^^ This line doesn't match the subject or the content of the patch.

> Signed-off-by: Yuan Yao <yao.yuan@....com>
> Acked-by: Rob Herring <robh@...nel.org>
> ---
> Changed in v4:
> No changes.
> 
> Changed in v3:
> Add the modifier for new compatible string like:
> "fsl,ls2080a-dspi" followed by "fsl,ls2085a-dspi"
> 
> Changed in v2:
> Update my email to <yao.yuan@....com>
> ---
>  Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt | 5 ++++-

^^ What is this change doing in this series anyway? You're touching MTD
stuff, not SPI stuff, and this string doesn't get used in any driver. Is
this controller somehow related, or is it a separate IP block that
happens to be on some of the same SoCs?

Anyway, you should send this kind of stuff to the SPI list, not the MTD
one.

Regards,
Brian

>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt b/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt
> index fa77f87..1ad0fe3 100644
> --- a/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt
> +++ b/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt
> @@ -1,7 +1,10 @@
>  ARM Freescale DSPI controller
>  
>  Required properties:
> -- compatible : "fsl,vf610-dspi", "fsl,ls1021a-v1.0-dspi", "fsl,ls2085a-dspi"
> +- compatible : "fsl,vf610-dspi", "fsl,ls1021a-v1.0-dspi",
> +		"fsl,ls2085a-dspi"
> +		or
> +		"fsl,ls2080a-dspi" followed by "fsl,ls2085a-dspi"
>  - reg : Offset and length of the register set for the device
>  - interrupts : Should contain SPI controller interrupt
>  - clocks: from common clock binding: handle to dspi clock.
> -- 
> 2.1.0.27.g96db324
>