linux-kernel - Re: [PATCH] gpio: xgene: Fix kconfig for standby GIPO contoller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 Mar 2016 21:03:04 +0100
From:	Matthias Brugger <mbrugger@...e.com>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Alexandre Courbot <gnurou@...il.com>,
	Quan Nguyen <qnguyen@....com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: xgene: Fix kconfig for standby GIPO contoller

On Fri, 2016-03-11 at 23:01 +0700, Linus Walleij wrote:
> On Fri, Mar 4, 2016 at 5:59 PM, Matthias Brugger <mbrugger@...e.com>
> wrote:
> 
> > The standby GPIO controller can be used as a interrupt controller.
> > Select GPIOLIB_IRQCHIP when compiling this driver. Otherwise we get
> > a compilation error:
> > 
> > drivers/gpio/gpio-xgene-sb.c: In function 'xgene_gpio_sb_probe':
> > drivers/gpio/gpio-xgene-sb.c:312:10: error: 'struct gpio_chip' has
> > no member named 'irqdomain'
> >   priv->gc.irqdomain = priv->irq_domain;
> >           ^
> > scripts/Makefile.build:295: recipe for target 'drivers/gpio/gpio
> > -xgene-sb.o' failed
> > make[2]: *** [drivers/gpio/gpio-xgene-sb.o] Error 1
> > 
> > Fixes: 1013fc41 "gpio: xgene: Enable X-Gene standby GPIO as
> > interrupt controller"
> > Signed-off-by: Matthias Brugger <mbrugger@...e.com>
> 
> Quan's patch exporting the symbols has been merged by tglx
> so dropping this.
> 

Thanks for the info.

Actually this is v1 [1] of the patch, which just addresses the
GPIOLIB_IRQCHIP problem?
With Quan's patch this should still be present.

[1] https://patchwork.kernel.org/patch/8502401/