linux-kernel - Re: [PATCH] USB: cdc-acm: add support for Sagem Monetel ELC930

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 12 Mar 2016 16:27:29 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Nicolas Saenz Julienne <nicolassaenzj@...il.com>
Cc:	oliver@...kum.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: cdc-acm: add support for Sagem Monetel ELC930

On Sat, Mar 12, 2016 at 11:44:51PM +0000, Nicolas Saenz Julienne wrote:
> Signed-off-by: Nicolas Saenz Julienne <nicolassaenzj@...il.com>
> ---
>  drivers/usb/class/cdc-acm.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
> index fa4e239..9831607 100644
> --- a/drivers/usb/class/cdc-acm.c
> +++ b/drivers/usb/class/cdc-acm.c
> @@ -1681,6 +1681,9 @@ static const struct usb_device_id acm_ids[] = {
>  	{ USB_DEVICE(0x079b, 0x000f), /* BT On-Air USB MODEM */
>  	.driver_info = NO_UNION_NORMAL, /* has no union descriptor */
>  	},
> +	{ USB_DEVICE(0x079b, 0x0088), /* SAGEM Monetel ELC930 */
> +	.driver_info = NO_UNION_NORMAL, /* has no union descriptor */
> +	},

Why is this needed?  Does the descriptors not properly set the class
device?

thanks,

greg k-h