linux-kernel - [PATCH] direct-io: Deinline dio_send_cur

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 13 Mar 2016 22:00:36 +0100
From:	Denys Vlasenko <dvlasenk@...hat.com>
To:	Al Viro <viro@...iv.linux.org.uk>
Cc:	Denys Vlasenko <dvlasenk@...hat.com>, Jens Axboe <axboe@...com>,
	Christoph Hellwig <hch@....de>, linux-kernel@...r.kernel.org
Subject: [PATCH] direct-io: Deinline dio_send_cur_page, save ~2000 bytes

This function compiles to 1070 bytes, 2 callsites

   text	   data	    bss	    dec	    hex	filename
   9559	     16	      0	   9575	   2567	direct-io.o.before3
   7587	     16	      0	   7603	   1db3	direct-io.o

Signed-off-by: Denys Vlasenko <dvlasenk@...hat.com>
CC: Al Viro <viro@...iv.linux.org.uk>
CC: Jens Axboe <axboe@...com>
CC: Christoph Hellwig <hch@....de>
CC: linux-kernel@...r.kernel.org
---
 fs/direct-io.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/direct-io.c b/fs/direct-io.c
index 729c902..469baf7 100644
--- a/fs/direct-io.c
+++ b/fs/direct-io.c
@@ -710,7 +710,7 @@ static inline int dio_bio_add_page(struct dio_submit *sdio)
  * The caller of this function is responsible for removing cur_page from the
  * dio, and for dropping the refcount which came from that presence.
  */
-static inline int dio_send_cur_page(struct dio *dio, struct dio_submit *sdio,
+static int dio_send_cur_page(struct dio *dio, struct dio_submit *sdio,
 		struct buffer_head *map_bh)
 {
 	int ret = 0;
-- 
1.8.1.4