lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 15 Mar 2016 20:55:35 -0700 From: Steve Muckle <steve.muckle@...aro.org> To: Michael Turquette <mturquette@...libre.com>, Peter Zijlstra <peterz@...radead.org> Cc: rjw@...ysocki.net, linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org, Juri.Lelli@....com, morten.rasmussen@....com, dietmar.eggemann@....com, vincent.guittot@...aro.org, Michael Turquette <mturquette+renesas@...libre.com> Subject: Re: [PATCH 5/8] sched/cpufreq: pass sched class into cpufreq_update_util Hi Mike, On 03/15/2016 03:06 PM, Michael Turquette wrote: >>> > > void cpufreq_set_freq_update_hook(int cpu, struct freq_update_hook *hook, >>> > > + void (*func)(struct freq_update_hook *hook, >>> > > + enum sched_class_util sched_class, >>> > > + u64 time, unsigned long util, >>> > > + unsigned long max)); >> > >> > Have you looked at the asm that generated? At some point you'll start >> > spilling on the stack and it'll be a god awful mess. >> > > Is your complaint about the enum that I added to the existing function > signature, or do you not like the original function signature[0] from > Rafael's patch, sans enum? The ARM procedure call standard has the first four arguments in registers so the addition of the enum above will start using the stack.
Powered by blists - more mailing lists