linux-kernel - Re: [PATCH 2/5] ARM: davinci: da8xx: add usb phy clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 16 Mar 2016 12:58:34 -0500
From:	David Lechner <david@...hnology.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	Sekhar Nori <nsekhar@...com>,
	Kevin Hilman <khilman@...nel.org>,
	Alan Stern <stern@...land.harvard.edu>, Bin Liu <b-liu@...com>,
	Petr Kulhavy <petr@...ix.com>
Cc:	Russell King <linux@....linux.org.uk>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Felipe Balbi <balbi@...nel.org>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH 2/5] ARM: davinci: da8xx: add usb phy clocks

On 03/16/2016 07:27 AM, Sergei Shtylyov wrote:
>>
>> +static struct clk usb20_clk = {
>> +    .name        = "usb20",
>> +    .parent        = &pll0_sysclk2,
>> +    .lpsc        = DA8XX_LPSC1_USB20,
>> +    .gpsc        = 1,
>> +};
>
>     Why move it?

For organization, to keep all of the USB clocks together. I can leave it 
alone if that is preferred.

>> +
>> +    /* Set the mux depending on the parent clock. */
>> +    if (clk->parent == &pll0_aux_clk)
>> +        val |= CFGCHIP2_USB2PHYCLKMUX;
>> +    else if (clk->parent == &usb_ref_clk)
>> +        val &= ~CFGCHIP2_USB2PHYCLKMUX;
>
>     Don't we have clk_set_parent()for that?

Yes. clk_set_parent() is already called in a loop for all clocks 
elsewhere, so not needed here.

---

Thank you for the careful review. I will address the other problems you 
pointed out.