linux-kernel - Re: [PATCH v5 2/6] module: preserve Elf information for livepatch modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 17 Mar 2016 04:28:06 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Jessica Yu <jeyu@...hat.com>
Cc:	kbuild-all@...org, Rusty Russell <rusty@...tcorp.com.au>,
	Josh Poimboeuf <jpoimboe@...hat.com>,
	Petr Mladek <pmladek@...e.com>, Jiri Kosina <jikos@...nel.org>,
	Jonathan Corbet <corbet@....net>,
	Miroslav Benes <mbenes@...e.cz>, linux-api@...r.kernel.org,
	live-patching@...r.kernel.org, x86@...nel.org,
	linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org,
	linux-doc@...r.kernel.org, Jessica Yu <jeyu@...hat.com>
Subject: Re: [PATCH v5 2/6] module: preserve Elf information for livepatch
 modules

Hi Jessica,

[auto build test WARNING on s390/features]
[also build test WARNING on v4.5 next-20160316]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Jessica-Yu/mostly-Arch-independent-livepatch/20160317-035230
base:   https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git features
config: xtensa-allyesconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=xtensa 

All warnings (new ones prefixed by >>):

   In file included from include/linux/kernel.h:13:0,
                    from include/linux/list.h:8,
                    from include/linux/module.h:9,
                    from include/linux/moduleloader.h:5,
                    from kernel/module.c:20:
   kernel/module.c: In function 'find_livepatch_modinfo':
   kernel/module.c:2767:10: error: expected ')' before 'mod'
             mod->name);
             ^
   include/linux/printk.h:236:21: note: in definition of macro 'pr_fmt'
    #define pr_fmt(fmt) fmt
                        ^
   kernel/module.c:2766:3: note: in expansion of macro 'pr_err'
      pr_err("%s: module is marked as livepatch module, but livepatch support is disabled"
      ^
>> kernel/module.c:2767:10: warning: format '%s' expects a matching 'char *' argument [-Wformat=]
             mod->name);
             ^
   include/linux/printk.h:236:21: note: in definition of macro 'pr_fmt'
    #define pr_fmt(fmt) fmt
                        ^
   kernel/module.c:2766:3: note: in expansion of macro 'pr_err'
      pr_err("%s: module is marked as livepatch module, but livepatch support is disabled"
      ^

vim +2767 kernel/module.c

  2751		} while (len);
  2752		return 0;
  2753	}
  2754	
  2755	#ifdef CONFIG_LIVEPATCH
  2756	static int find_livepatch_modinfo(struct module *mod, struct load_info *info)
  2757	{
  2758		mod->klp = get_modinfo(info, "livepatch") ? true : false;
  2759	
  2760		return 0;
  2761	}
  2762	#else /* !CONFIG_LIVEPATCH */
  2763	static int find_livepatch_modinfo(struct module *mod, struct load_info *info)
  2764	{
  2765		if (get_modinfo(info, "livepatch")) {
  2766			pr_err("%s: module is marked as livepatch module, but livepatch support is disabled"
> 2767			       mod->name);
  2768			return -ENOEXEC;
  2769		}
  2770	
  2771		return 0;
  2772	}
  2773	#endif /* CONFIG_LIVEPATCH */
  2774	
  2775	/* Sets info->hdr and info->len. */

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (44069 bytes)