linux-kernel - Re: WARNING: DT compatible string vendor "mips" appears un-documented

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 17 Mar 2016 08:04:43 -0500
From:	Rob Herring <robh@...nel.org>
To:	Antony Pavlov <antonynpavlov@...il.com>
Cc:	Ralf Baechle <ralf@...ux-mips.org>,
	Zubair Lutfullah Kakakhel <Zubair.Kakakhel@...tec.com>,
	Linux-MIPS <linux-mips@...ux-mips.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: WARNING: DT compatible string vendor "mips" appears un-documented

On Wed, Mar 16, 2016 at 10:02 PM, Antony Pavlov <antonynpavlov@...il.com> wrote:
> Hi all,
>
> checkpatch.pl notes that DT compatible string vendor "mips" appears un-documented.
>
> On the one hand there are several users of this vendor string:
>
>     linux$ git grep \"mips,
>     Documentation/devicetree/bindings/mips/img/xilfpga.txt: - compatible: Must be "mips,m14Kc".
>     Documentation/devicetree/bindings/mips/img/xilfpga.txt:                 compatible = "mips,m14Kc";
>     arch/mips/boot/dts/lantiq/danube.dtsi:                  compatible = "mips,mips24Kc";
>     arch/mips/boot/dts/qca/ar9132.dtsi:                     compatible = "mips,mips24Kc";
>     arch/mips/boot/dts/ralink/mt7620a.dtsi:                 compatible = "mips,mips24KEc";
>     arch/mips/boot/dts/ralink/rt2880.dtsi:                  compatible = "mips,mips4KEc";
>     arch/mips/boot/dts/ralink/rt3050.dtsi:                  compatible = "mips,mips24KEc";
>     arch/mips/boot/dts/ralink/rt3883.dtsi:                  compatible = "mips,mips74Kc";
>     arch/mips/boot/dts/xilfpga/microAptiv.dtsi:                     compatible = "mips,m14Kc";
>
> On the other hand we already have the "mti" vendor string:
>
>     linux$ grep MIPS Documentation/devicetree/bindings/vendor-prefixes.txt
>     mti    Imagination Technologies Ltd. (formerly MIPS Technologies Inc.)
>
> Can we add an another one vendor string for MIPS?

No.

It is called checkpatch.pl, not checkfile.pl (yes, I know it can check
files too). There are many warnings if you look at the tree as a
whole. The main point of the checks (at least for DT) is to not
introduce new warnings.

So mips is deprecated and shouldn't be used for new bindings (perhaps
mti is too as img? should be used now). Continuing to use the existing
strings is fine.

Rob