linux-kernel - Re: [PATCH v5 3/6] ARM: AM335x/AM437x: hwmod: Remove eQEP, ePWM and eCAP hwmod entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 17 Mar 2016 10:45:59 -0500
From:	"Franklin S Cooper Jr." <fcooper@...com>
To:	Rob Herring <robh@...nel.org>
CC:	<thierry.reding@...il.com>, <pawel.moll@....com>,
	<mark.rutland@....com>, <ijc+devicetree@...lion.org.uk>,
	<galak@...eaurora.org>, <bcousson@...libre.com>,
	<tony@...mide.com>, <linux@....linux.org.uk>, <paul@...an.com>,
	<linux-pwm@...r.kernel.org>, <devicetree@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-omap@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <vigneshr@...com>
Subject: Re: [PATCH v5 3/6] ARM: AM335x/AM437x: hwmod: Remove eQEP, ePWM and
 eCAP hwmod entries



On 03/17/2016 10:06 AM, Rob Herring wrote:
> On Mon, Mar 07, 2016 at 07:23:41PM -0600, Franklin S Cooper Jr wrote:
>> Devices that utilize the OCP registers and/or PRCM registers and
>> register bit fields should be modelled using hwmod. Since eQEP, ePWM and
> s/modelled/modeled/

Will fix.
>
>> eCAP don't fall under this category, remove their hwmod entries.
>>
>> Instead these clocks simply use the clock that is pass through by its
>> parent PWMSS. Therefore, PWMSS handles the clock for itself and its
>> subdevices.
> Are you breaking compatibility with old DTs here? 

No. The first patch makes sure that the ecap and ehrpwm get
their clocks from their parent which is all they care about.
Old dtbs will have hwmod entries for ecap and ehrpwm which
will end up not doing anything.
>  
>> Signed-off-by: Franklin S Cooper Jr <fcooper@...com>
>> ---
>>  .../devicetree/bindings/pwm/pwm-tiecap.txt         |  1 -
>>  .../devicetree/bindings/pwm/pwm-tiehrpwm.txt       |  7 +-
>>  .../mach-omap2/omap_hwmod_33xx_43xx_common_data.h  | 18 -----
>>  .../omap_hwmod_33xx_43xx_interconnect_data.c       | 64 -----------------
>>  .../mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c | 84 ----------------------
>>  arch/arm/mach-omap2/omap_hwmod_33xx_data.c         |  9 ---
>>  arch/arm/mach-omap2/omap_hwmod_43xx_data.c         | 54 --------------
>>  7 files changed, 4 insertions(+), 233 deletions(-)