linux-kernel - Re: [PATCH] drivers: staging: unisys: visornic: Fixed block comment coding style warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 16 Mar 2016 19:06:50 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Gavin O'Leary <gavinoleary3@...il.com>
Cc:	david.kershner@...sys.com, benjamin.romer@...sys.com,
	sparmaintainer@...sys.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: staging: unisys: visornic: Fixed block comment
 coding style warnings

On Wed, Mar 16, 2016 at 07:01:51PM -0700, Gavin O'Leary wrote:
> Fixed block comment checkpatch warnings.
> 
> Signed-off-by: Gavin O'Leary <gavinoleary3@...il.com>
> ---
>  drivers/staging/unisys/visornic/visornic_main.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic/visornic_main.c
> index 0519470..eefbacc 100644
> --- a/drivers/staging/unisys/visornic/visornic_main.c
> +++ b/drivers/staging/unisys/visornic/visornic_main.c
> @@ -1315,12 +1315,14 @@ visornic_rx(struct uiscmdrsp *cmdrsp)
>  				}
>  				if (found_mc)
>  					break;	/* accept packet, dest
> -						   matches a multicast
> -						   address */
> +						 * matches a multicast
> +						 * address
> +						 */

That looks horrible, don't you think?

>  			}
>  		} else if (skb->pkt_type == PACKET_HOST) {
>  			break;	/* accept packet, h_dest must match vnic
> -				   mac address */
> +				 * mac address
> +				 */

Same here.

Please fix up to look better, that's your goal, right?

thanks,

greg k-h