lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 16 Mar 2016 23:48:49 -0300 From: Vinicius Tinti <viniciustinti@...il.com> To: herbert@...dor.apana.org.au, davem@...emloft.net, tglx@...utronix.de, mingo@...hat.com, hpa@...or.com, x86@...nel.org Cc: linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org, Vinicius Tinti <viniciustinti@...il.com> Subject: [PATCH] x86: Avoid undefined behavior in macro expansion C11 standard (at 6.10.3.3) says that ## operator (paste) has undefined behavior when one of the result operands is not a valid preprocessing token. Therefore the macro expansion may depend on compiler implementation which may or no preserve the leading white space. Moreover other places in kernel use CONCAT(a,b) instead of CONCAT(a, b). Changing favors concise usage. Signed-off-by: Vinicius Tinti <viniciustinti@...il.com> Acked-by: Behan Webster <behanw@...verseincode.com> --- arch/x86/crypto/aes_ctrby8_avx-x86_64.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/crypto/aes_ctrby8_avx-x86_64.S b/arch/x86/crypto/aes_ctrby8_avx-x86_64.S index a916c4a..7a71553 100644 --- a/arch/x86/crypto/aes_ctrby8_avx-x86_64.S +++ b/arch/x86/crypto/aes_ctrby8_avx-x86_64.S @@ -93,7 +93,7 @@ #define tmp %r10 #define DDQ(i) CONCAT(ddq_add_,i) -#define XMM(i) CONCAT(%xmm, i) +#define XMM(i) CONCAT(%xmm,i) #define DDQ_DATA 0 #define XDATA 1 #define KEY_128 1 -- 2.7.3
Powered by blists - more mailing lists