linux-kernel - Re: [PATCH] staging: netlogic: Fixed alignment of parantheseis checkpatch warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 19 Mar 2016 18:47:43 -0700
From:	Joe Perches <joe@...ches.com>
To:	Parth Sane <laerdevstudios@...il.com>, gregkh@...uxfoundation.org
Cc:	brcnakalin@...il.com, shraddha.6596@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: netlogic: Fixed alignment of parantheseis
 checkpatch warning

On Sun, 2016-03-20 at 01:42 +0000, Parth Sane wrote:
> Fixed alignment of paranthesis as per checkpatch.

The subject prefix [PATCH] should be numbered
with the revision like [PATCH v2]

> Please ignore earlier sent patch for paranthesis check and use this one. 

This bit of your email should go below the ---
separator line.

Otherwise it goes into the git commit log which
isn't desired.

Trivially, you've misspelled parenthesis

> Signed-off-by: Parth Sane <laerdevstudios@...il.com>
> 
> ---
>  drivers/staging/netlogic/platform_net.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c
> index daee1b2..dde20d5 100644
> --- a/drivers/staging/netlogic/platform_net.c
> +++ b/drivers/staging/netlogic/platform_net.c
> @@ -120,10 +120,9 @@ static struct platform_device *gmac_controller2_init(void *gmac0_addr)
>  	for (mac = 0; mac < 4; mac++) {
>  		ndata1.tx_stnid[mac] = FMN_STNID_GMAC1_TX0 + mac;
>  		ndata1.phy_addr[mac] = mac + 4 + 0x10;
> -

Also trivially, there's no reason to delete this line.

>  		xlr_resource_init(&xlr_net1_res[mac * 2],
> -				xlr_gmac_offsets[mac + 4],
> -				xlr_gmac_irqs[mac + 4]);
> +				  xlr_gmac_offsets[mac + 4],
> +				  xlr_gmac_irqs[mac + 4]);
>  	}
>  	xlr_net_dev1.num_resources = 8;
>