linux-kernel - Re: [PATCH v2] ARM: DMA: Fix kzalloc flags in __dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 20 Mar 2016 15:49:15 +0900
From:	Alexandre Courbot <gnurou@...il.com>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	Alexandre Courbot <acourbot@...dia.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Rabin Vincent <rabin@....in>,
	Thierry Reding <thierry.reding@...il.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] ARM: DMA: Fix kzalloc flags in __dma_alloc

On Fri, Mar 18, 2016 at 7:58 PM, Russell King - ARM Linux
<linux@....linux.org.uk> wrote:
> On Fri, Mar 18, 2016 at 06:28:49PM +0900, Alexandre Courbot wrote:
>> Commit 19e6e5e5392b ("ARM: 8547/1: dma-mapping: store buffer
>> information") allocates a structure meant for internal buffer management
>> with the GFP flags of the buffer itself. This can trigger the following
>> safeguard in the slab/slub allocator:
>>
>>       if (unlikely(flags & GFP_SLAB_BUG_MASK)) {
>>               pr_emerg("gfp: %u\n", flags & GFP_SLAB_BUG_MASK);
>>               BUG();
>>       }
>>
>> Fix this by filtering the flags that make the slab allocator unhappy.
>>
>> Signed-off-by: Alexandre Courbot <acourbot@...dia.com>
>> Cc: Rabin Vincent <rabin@....in>
>
> Looks much better than the original.  Please send it to the patch system,
> thanks.

Just did that, thanks!