linux-kernel - Re: [PATCH] iio: light: tsl2563: Remove flush_scheduled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 20 Mar 2016 11:05:11 +0000
From:	Jonathan Cameron <jic23@...nel.org>
To:	Amitoj Kaur Chawla <amitoj1606@...il.com>, knaack.h@....de,
	lars@...afoo.de, pmeerw@...erw.net, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc:	tj@...nel.org, outreachy-kernel@...glegroups.com
Subject: Re: [PATCH] iio: light: tsl2563: Remove flush_scheduled_work

On 17/03/16 13:55, Amitoj Kaur Chawla wrote:
> flush_scheduled_work is scheduled for deprecation.
> Replace cancel_delayed_work and flush_scheduled_work with
> cancel_delayed_work_sync instead to ensure there is no pending or
> running work item.
> 
> Since there is only one work item, chip->poweroff_work, there are 
> no further dependencies of flush_scheduled_work().
> 
> Acked-by: Tejun Heo <tj@...nel.org>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@...il.com>
Applied to the togreg branch of iio.git - initially pushed out as testing
for the autobuilders to play with it.

Thanks,

Jonathan
> ---
>  drivers/iio/light/tsl2563.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/light/tsl2563.c b/drivers/iio/light/tsl2563.c
> index 12731d6..57b108c 100644
> --- a/drivers/iio/light/tsl2563.c
> +++ b/drivers/iio/light/tsl2563.c
> @@ -806,8 +806,7 @@ static int tsl2563_probe(struct i2c_client *client,
>  	return 0;
>  
>  fail:
> -	cancel_delayed_work(&chip->poweroff_work);
> -	flush_scheduled_work();
> +	cancel_delayed_work_sync(&chip->poweroff_work);
>  	return err;
>  }
>  
>