linux-kernel - [PATCH] [JANITOR] Actually use the calculated cnt in kernel/trace/ring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 21 Mar 2016 21:28:39 +0200
From:	Mika Kukkonen <mikukkon@....fi>
To:	rostedt@...dmis.org
Cc:	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: [PATCH] [JANITOR] Actually use the calculated cnt in kernel/trace/ring_buffer.c

Was deleting an old github kernel tree and noticed this one line patch
I had made years back. Can't remember the compiler warning anymore but
clearly it complained about pointless assigment to cnt since it is not
used after that, although to me it looks like it should.

Signed-off-by: Mika Kukkonen <mikukkon@....fi>

diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
index 95181e3..22d1007 100644
--- a/kernel/trace/ring_buffer.c
+++ b/kernel/trace/ring_buffer.c
@@ -4756,7 +4756,7 @@ static __init int rb_write_something(struct
rb_test_data *data, bool nested)
        cnt = data->cnt + (nested ? 27 : 0);

        /* Multiply cnt by ~e, to make some unique increment */
-       size = (data->cnt * 68 / 25) % (sizeof(rb_string) - 1);
+       size = (cnt * 68 / 25) % (sizeof(rb_string) - 1);

        len = size + sizeof(struct rb_item);

--MiKu