linux-kernel - [PATCH] clocksource/drivers/pistachio: Correct output format of PTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 22 Mar 2016 01:42:07 +0200
From:	Vladimir Zapolskiy <vz@...ia.com>
To:	Daniel Lezcano <daniel.lezcano@...aro.org>,
	Thomas Gleixner <tglx@...utronix.de>
Cc:	linux-kernel@...r.kernel.org, Jisheng Zhang <jszhang@...vell.com>,
	Ezequiel Garcia <ezequiel.garcia@...tec.com>
Subject: [PATCH] clocksource/drivers/pistachio: Correct output format of PTR_ERR()

Use signed integer output in the pr_err() string format, here
PTR_ERR() value is negative and it should be reported in human
readable way.

Signed-off-by: Vladimir Zapolskiy <vz@...ia.com>
Cc: Jisheng Zhang <jszhang@...vell.com>
Cc: Ezequiel Garcia <ezequiel.garcia@...tec.com>
---
I've occasionally found this issue, which most probably is copy-pasted
from/to drivers/clocksource/time-lpc32xx.c and recently fixed by commit
d662ed204357 ("clocksource/drivers/lpc32: Correct pr_err() output format").

 drivers/clocksource/time-pistachio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clocksource/time-pistachio.c b/drivers/clocksource/time-pistachio.c
index 3269d9e..376e59b 100644
--- a/drivers/clocksource/time-pistachio.c
+++ b/drivers/clocksource/time-pistachio.c
@@ -163,7 +163,7 @@ static void __init pistachio_clksrc_of_init(struct device_node *node)
 
 	periph_regs = syscon_regmap_lookup_by_phandle(node, "img,cr-periph");
 	if (IS_ERR(periph_regs)) {
-		pr_err("cannot get peripheral regmap (%lu)\n",
+		pr_err("cannot get peripheral regmap (%ld)\n",
 		       PTR_ERR(periph_regs));
 		return;
 	}
@@ -176,7 +176,7 @@ static void __init pistachio_clksrc_of_init(struct device_node *node)
 
 	sys_clk = of_clk_get_by_name(node, "sys");
 	if (IS_ERR(sys_clk)) {
-		pr_err("clock get failed (%lu)\n", PTR_ERR(sys_clk));
+		pr_err("clock get failed (%ld)\n", PTR_ERR(sys_clk));
 		return;
 	}
 
-- 
2.1.4