linux-kernel - Re: [PATCH] Security: Keys: Added derived keytype

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 22 Mar 2016 10:04:11 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Kirill Marinushkin <k.marinushkin@...il.com>
Cc:	kbuild-all@...org, dhowells@...hat.com,
	linux-kernel@...r.kernel.org, keyrings@...r.kernel.org,
	linux-security-module@...r.kernel.org, k.marinushkin@...il.com
Subject: Re: [PATCH] Security: Keys: Added derived keytype

Hi Kirill,

[auto build test WARNING on v4.5-rc7]
[also build test WARNING on next-20160321]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Kirill-Marinushkin/Security-Keys-Added-derived-keytype/20160322-084809
config: sparc64-allyesconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=sparc64 

All warnings (new ones prefixed by >>):

   security/keys/derived.c: In function 'parse_options':
>> security/keys/derived.c:217:15: warning: assignment from incompatible pointer type
       usalt.lenp = &payload->saltlen;
                  ^

vim +217 security/keys/derived.c

   201			switch (token) {
   202	
   203			case OPT_SHORT_SALT: /* salt */
   204			case OPT_LONG_SALT:
   205				templen = args[0].to - args[0].from;
   206				if (templen < 0 || templen > SALT_MAX_SIZE) {
   207					pr_err(PREFIX "invalid salt length");
   208					return -EINVAL;
   209				}
   210				payload->salt = kstrndup(args[0].from, templen, GFP_KERNEL);
   211				if (!payload->salt) {
   212					pr_err(PREFIX "salt alloc failed");
   213					return -ENOMEM;
   214				}
   215				payload->saltlen = templen;
   216				usalt.data = payload->salt;
 > 217				usalt.lenp = &payload->saltlen;
   218				break;
   219	
   220			case OPT_SHORT_ITER: /* iterations */
   221			case OPT_LONG_ITER:
   222				if (kstrtou64(args[0].from, 0, &tempul)
   223						|| tempul == 0
   224						|| tempul > ITER_MAX_VAL) {
   225					pr_err(PREFIX "invalid iterations number");

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (45105 bytes)