linux-kernel - Re: [PATCH 1/3] rbd: use KMEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 22 Mar 2016 17:55:43 +0100
From:	Ilya Dryomov <idryomov@...il.com>
To:	Geliang Tang <geliangtang@....com>
Cc:	Sage Weil <sage@...hat.com>, Alex Elder <elder@...nel.org>,
	Ceph Development <ceph-devel@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] rbd: use KMEM_CACHE macro

On Sun, Mar 13, 2016 at 8:17 AM, Geliang Tang <geliangtang@....com> wrote:
> Use KMEM_CACHE() instead of kmem_cache_create() to simplify the code.
>
> Signed-off-by: Geliang Tang <geliangtang@....com>
> ---
>  drivers/block/rbd.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index 4a87678..70eba86 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -5643,18 +5643,12 @@ static void rbd_sysfs_cleanup(void)
>  static int rbd_slab_init(void)
>  {
>         rbd_assert(!rbd_img_request_cache);
> -       rbd_img_request_cache = kmem_cache_create("rbd_img_request",
> -                                       sizeof (struct rbd_img_request),
> -                                       __alignof__(struct rbd_img_request),
> -                                       0, NULL);
> +       rbd_img_request_cache = KMEM_CACHE(rbd_img_request, 0);
>         if (!rbd_img_request_cache)
>                 return -ENOMEM;
>
>         rbd_assert(!rbd_obj_request_cache);
> -       rbd_obj_request_cache = kmem_cache_create("rbd_obj_request",
> -                                       sizeof (struct rbd_obj_request),
> -                                       __alignof__(struct rbd_obj_request),
> -                                       0, NULL);
> +       rbd_obj_request_cache = KMEM_CACHE(rbd_obj_request, 0);
>         if (!rbd_obj_request_cache)
>                 goto out_err;
>

Applied.

Thanks,

                Ilya