linux-kernel - [PATCH 4/5] staging: xgifb: fix comparison order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 27 Mar 2016 15:13:02 -0400
From:	Clifton Barnes <clifton.a.barnes@...il.com>
To:	arnaud.patard@...-net.org
Cc:	kernel-janitors@...r.kernel.org, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org,
	Clifton Barnes <clifton.a.barnes@...il.com>
Subject: [PATCH 4/5] staging: xgifb: fix comparison order

fix checkpatch.pl warning about 'Comparisons should place the constant
on the right side of the test'

Signed-off-by: Clifton Barnes <clifton.a.barnes@...il.com>
---
 drivers/staging/xgifb/vb_setmode.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
index 50c8ea4..8bf253c 100644
--- a/drivers/staging/xgifb/vb_setmode.c
+++ b/drivers/staging/xgifb/vb_setmode.c
@@ -1208,7 +1208,7 @@ static void const *XGI_GetLcdPtr(struct XGI330_LCDDataTablStruct const *table,
 		if (pVBInfo->LCDInfo & EnableScalingLCD)
 			tempdx &= (~PanelResInfo);
 
-		if (table[i].PANELID == tempdx) {
+		if (tempdx == table[i].PANELID) {
 			tempbx = table[i].MASK;
 			tempdx = pVBInfo->LCDInfo;
 
@@ -3902,7 +3902,7 @@ static struct XGI301C_Tap4TimingStruct const
 
 	i = 0;
 	while (Tap4TimingPtr[i].DE != 0xFFFF) {
-		if (Tap4TimingPtr[i].DE == tempax)
+		if (tempax == Tap4TimingPtr[i].DE)
 			break;
 		i++;
 	}
-- 
1.9.1