linux-kernel - [PATCH] drivers/mtd/chips/cfi_cmdset_0020.c: Deinline do_erase

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 30 Mar 2016 15:01:00 +0200
From:	Denys Vlasenko <dvlasenk@...hat.com>
To:	David Woodhouse <David.Woodhouse@...el.com>
Cc:	Denys Vlasenko <dvlasenk@...hat.com>,
	Brian Norris <computersforpeace@...il.com>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	Artem Bityutskiy <artem.bityutskiy@...ux.intel.com>,
	linux-kernel@...r.kernel.org
Subject: [PATCH] drivers/mtd/chips/cfi_cmdset_0020.c: Deinline do_erase_oneblock

This function compiles to 2142 bytes of machine code.
In C, the function is about 150 lines long.

It has only one callsite, but forced inlining that much code
makes gcc generate worse code. Let gcc itself decide what to do.

    text     data      bss       dec     hex filename
95943075 20860288 35991552 152794915 91b7723 vmlinux_before
95942947 20860288 35991552 152794787 91b76a3 vmlinux

Signed-off-by: Denys Vlasenko <dvlasenk@...hat.com>
CC: David Woodhouse <David.Woodhouse@...el.com>
CC: Brian Norris <computersforpeace@...il.com>
CC: Dan Carpenter <dan.carpenter@...cle.com>
CC: Artem Bityutskiy <artem.bityutskiy@...ux.intel.com>
CC: linux-kernel@...r.kernel.org
---
 drivers/mtd/chips/cfi_cmdset_0020.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/chips/cfi_cmdset_0020.c b/drivers/mtd/chips/cfi_cmdset_0020.c
index 9a1a6ff..c740bd2 100644
--- a/drivers/mtd/chips/cfi_cmdset_0020.c
+++ b/drivers/mtd/chips/cfi_cmdset_0020.c
@@ -728,7 +728,7 @@ write_error:
 }
 
 
-static inline int do_erase_oneblock(struct map_info *map, struct flchip *chip, unsigned long adr)
+static int do_erase_oneblock(struct map_info *map, struct flchip *chip, unsigned long adr)
 {
 	struct cfi_private *cfi = map->fldrv_priv;
 	map_word status, status_OK;
-- 
2.1.0