linux-kernel - Re: [PATCH] tty: amba-pl011: Use 32-bit accesses for SBSA UART

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 30 Mar 2016 13:11:17 -0500
From:	Timur Tabi <timur@...eaurora.org>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Christopher Covington <cov@...eaurora.org>,
	Andre Przywara <andre.przywara@....com>,
	Russell King <linux@....linux.org.uk>,
	Jiri Slaby <jslaby@...e.com>, linux-serial@...r.kernel.org,
	linux-kernel@...r.kernel.org, Jon Masters <jcm@...hat.com>,
	Mark Langsdorf <mlangsdo@...hat.com>,
	Dave Martin <dave.martin@...aro.org>,
	Aleksey Makarov <aleksey.makarov@...aro.org>
Subject: Re: [PATCH] tty: amba-pl011: Use 32-bit accesses for SBSA UART

Greg Kroah-Hartman wrote:
> On Wed, Mar 30, 2016 at 12:01:56PM -0500, Timur Tabi wrote:
>> Greg Kroah-Hartman wrote:
>>> If this isn't a bug fix or regression fix, it's not ok for 4.6-final, it
>>> will have to wait for 4.7-rc1.
>>
>> It fixes a problem on our platform (QDF2432).  Without this patch, we can't
>> use the PL011 at all.
>
> Did it ever work before?  Or is this new functionality?

No, it never worked before, so it's not a regression.  I guess it all 
depends on how you define "fix".  The driver loads and attempts to use 
the hardware, but it fails without this patch.  The system locks up 
completely (I guess it throws an unhandled exception or something).

I guess if you take a very limited definition of "fix", then this isn't 
a fix.  I can understand if you didn't want to take it for 4.6-rc7 or 
something, but for 4.6-rc2, I don't think it's inappropriate.

That's my two cents.  We'd like to see it in 4.6-rc2, but the decision 
is yours.

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum, a Linux Foundation collaborative project.