linux-kernel - Re: [RFC PATCH 12/12] IMA: Use the the system trusted keyrings instead of .ima

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 31 Mar 2016 18:18:22 -0400
From:	Mimi Zohar <zohar@...ux.vnet.ibm.com>
To:	David Howells <dhowells@...hat.com>
Cc:	linux-security-module@...r.kernel.org, keyrings@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 12/12] IMA: Use the the system trusted keyrings
 instead of .ima_mok [ver #3]

On Thu, 2016-03-31 at 11:55 -0400, Mimi Zohar wrote:
> On Thu, 2016-03-31 at 16:18 +0100, David Howells wrote:
> > Mimi Zohar <zohar@...ux.vnet.ibm.com> wrote:
> 
> > > > You said you didn't want this option above (to quote: In this patch, the
> > > > choice should be between checking just the builtin trusted keys or both the
> > > > builtin trusted and secondary keys.)
> > > 
> > > Does the ability of adding builtin X.509 certificates directly to the
> > > IMA keyring already exist or is it something that still needs to be
> > > done?   Assuming the latter, this option would be added with the ability
> > > of adding X.509 certificates directly to the IMA keyring.
> > 
> > I don't know what you mean by "directly" here.  Even without this patch, you
> > can already add X.509 certs to the .ima keyring, both at compile time
> 
> I'm must be missing something obvious here.  I need to review the
> patches again.  The builtin keys are loaded onto
> the .builtin_trusted_keys keyring, not the IMA keyring.is the

The only place where  "KEY_ALLOC_BYPASS_RESTRICTION" is specified is in
load_system_certificate_list(), when adding keys to
the .builtin_trusted_keys keyring.  There is no other set of keys
builtin and added to the IMA keyring.

Mimi