linux-kernel - Re: [PATCH 2/2] lightnvm: use relative logical address in rrpc_l2p

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 31 Mar 2016 11:11:26 +0200
From:	Matias Bjørling <mb@...htnvm.io>
To:	Wenwei Tao <ww.tao0320@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-block@...r.kernel.org
Subject: Re: [PATCH 2/2] lightnvm: use relative logical address in
 rrpc_l2p_update

On 03/30/2016 04:28 PM, Wenwei Tao wrote:
> Since every target now has their own logical address area,
> we should deal trans_map and rev_trans_map with relative
> logical address instead of the global one.
>
> Signed-off-by: Wenwei Tao <ww.tao0320@...il.com>
> ---
>   drivers/lightnvm/rrpc.c | 12 ++++++++----
>   1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/lightnvm/rrpc.c b/drivers/lightnvm/rrpc.c
> index 516a045..2279bd7 100644
> --- a/drivers/lightnvm/rrpc.c
> +++ b/drivers/lightnvm/rrpc.c
> @@ -998,10 +998,14 @@ static int rrpc_l2p_update(u64 slba, u32 nlb, __le64 *entries, void *private)
>   {
>   	struct rrpc *rrpc = (struct rrpc *)private;
>   	struct nvm_dev *dev = rrpc->dev;
> -	struct rrpc_addr *addr = rrpc->trans_map + slba;
> -	struct rrpc_rev_addr *raddr = rrpc->rev_trans_map;
> -	u64 elba = slba + nlb;
> -	u64 i;
> +	struct rrpc_addr *addr;
> +	struct rrpc_rev_addr *raddr;
> +	u64 elba, i;
> +
> +	slba -= rrpc->soffset >> (ilog2(dev->sec_size) - 9);
> +	addr = rrpc->trans_map + slba;
> +	raddr = rrpc->rev_trans_map;
> +	elba = slba + nlb;
>
>   	if (unlikely(elba > dev->total_secs)) {
>   		pr_err("nvm: L2P data from device is out of bounds!\n");
>

Hi Wenwei,

How about storing the value of "rrpc->soffset >> (ilog2(dev->sec_size) - 
9)" in rrpc->soffset. That let us only do the shifting for get/put area 
calls.