linux-kernel - Re: [PATCH] block: partition: initialize percpuref before sending out KOBJ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 31 Mar 2016 10:22:54 +0800
From:	Ming Lei <ming.lei@...onical.com>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Jens Axboe <axboe@...com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-block@...r.kernel.org, Naveen Kaje <nkaje@...eaurora.org>,
	stable <stable@...r.kernel.org>
Subject: Re: [PATCH] block: partition: initialize percpuref before sending out KOBJ_ADD

On Thu, Mar 31, 2016 at 1:43 AM, Christoph Hellwig <hch@...radead.org> wrote:
>> +     if (err) {
>> +             if (flags & ADDPART_FLAG_WHOLEDISK)
>> +                     goto out_remove_file;
>> +             goto out_del;
>> +     }
>
> I'd rather have that if around the actual device_remove_file at the
> label, and jump to out_remove_file unconditionally.

OK, looks better.

>
> Otherwise this looks fine to me.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-block" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html