linux-kernel - Re: [PATCH v2] spi: rockchip: fix warning of static check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 31 Mar 2016 10:52:09 -0700
From:	Doug Anderson <dianders@...omium.org>
To:	Shawn Lin <shawn.lin@...k-chips.com>
Cc:	Mark Brown <broonie@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	linux-spi@...r.kernel.org
Subject: Re: [PATCH v2] spi: rockchip: fix warning of static check

Shawn,

On Wed, Mar 30, 2016 at 8:11 PM, Shawn Lin <shawn.lin@...k-chips.com> wrote:
> Use dma_request_chan instead of dma_request_slave_channel,
> in this case we can check EPROBE_DEFER without static
> warning.

Technically this is more than just a warning fix.  The previous commit
61cadcf46cfd ("spi: rockchip: check requesting dma channel with
EPROBE_DEFER") could never have done what it was supposed to do
because dma_request_slave_channel() could never return EPROBE_DEFER.
...so really this makes the previous commit work properly.


> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Cc: Doug Anderson <dianders@...omium.org>
> Cc: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Shawn Lin <shawn.lin@...k-chips.com>
>
> ---
>
> Changes in v2:
> - use dma_request_chan and replace IS_ERR_OR_NULL()
>   with IS_ERR
> - do the same for rx
>
>  drivers/spi/spi-rockchip.c | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)

Reviewed-by: Douglas Anderson <dianders@...omium.org>