linux-kernel - Re: [PATCH] regulator: core: Use parent voltage from the supply when bypassed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 31 Mar 2016 10:55:27 -0700
From:	Mark Brown <broonie@...nel.org>
To:	Jon Hunter <jonathanh@...dia.com>
Cc:	Liam Girdwood <lgirdwood@...il.com>, linux-kernel@...r.kernel.org,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH] regulator: core: Use parent voltage from the supply when
 bypassed

On Thu, Mar 31, 2016 at 03:27:58PM +0100, Jon Hunter wrote:
> On 30/03/16 18:32, Mark Brown wrote:

> > +		if (bypassed) {
> > +			if (rdev->supply) {
> > +				ret = _regulator_get_voltage(rdev->supply->rdev);

> Should this be a return here?

Gnargh, yes.

> I gave this a quick test on tegra124 having populated the
> get/set_bypass() operators for the as3722. In this case, there is still
> a problem because _regulator_get_voltage() is called during regulator
> registration when set_machine_constraints() is called, which is before
> we have called regulator_register_resolve_supply(). Therefore, it seems
> to me that we still need to resolve the supply before we call
> set_machine_constraints().

OK, we need to change the code there to defer probe in the case where
the device is in bypass mode as well.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)