linux-kernel - Re: [PATCH v12 3/9] added UFS 2.0 capabilities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 1 Apr 2016 10:19:15 +0100
From:	Joao Pinto <Joao.Pinto@...opsys.com>
To:	"Winkler, Tomas" <tomas.winkler@...el.com>,
	"Joao.Pinto@...opsys.com" <Joao.Pinto@...opsys.com>
CC:	"vinholikatti@...il.com" <vinholikatti@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"hch@...radead.org" <hch@...radead.org>,
	"akinobu.mita@...il.com" <akinobu.mita@...il.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"gbroner@...eaurora.org" <gbroner@...eaurora.org>,
	"subhashj@...eaurora.org" <subhashj@...eaurora.org>,
	"CARLOS.PALMINHA@...opsys.com" <CARLOS.PALMINHA@...opsys.com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"mark.rutland@....com" <mark.rutland@....com>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	"julian.calaby@...il.com" <julian.calaby@...il.com>,
	"arnd@...db.de" <arnd@...db.de>
Subject: Re: [PATCH v12 3/9] added UFS 2.0 capabilities

On 3/31/2016 9:27 PM, Winkler, Tomas wrote:
> On Thu, 2016-03-31 at 19:57 +0100, Joao Pinto wrote:
>> Adding UFS 2.0 support to the UFS core driver.
>>
>> Signed-off-by: Joao Pinto <jpinto@...opsys.com>
> 
> Looks good to me, though not tested yet
> Tomas

I have tested the build in a x86 and ARC. Also tested the functionality by using
a HAPS-DX FPGA with the UFS 2.0 design + MPHY G210.

> 
>> ---
>> Changes v11->v12 (Tomas Winkler):
>> - devicetree binding tweak was moved to a separated patch
>> - unipro tweaks were moved to a separated patch
>> - ufshcd_compose_upiu was decomposed in 2 functions

[snip]

>> +enum {
>> +	UTP_CMD_TYPE_UFS_STORAGE	= 0x1,
>> +};
>> +
>>  enum {
>>  	UTP_SCSI_COMMAND		= 0x00000000,
>>  	UTP_NATIVE_UFS_COMMAND		= 0x10000000,

If you need anything else, please let me know.

Thanks.
Joao