linux-kernel - Re: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI commmand timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 01 Apr 2016 13:49:53 +0300
From:	Mathias Nyman <mathias.nyman@...ux.intel.com>
To:	Rajesh Bhagat <rajesh.bhagat@....com>
CC:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Sriram Dash <sriram.dash@....com>
Subject: Re: [PATCH] usb: xhci: Fix incomplete PM resume operation due to
 XHCI commmand timeout

On 01.04.2016 06:55, Rajesh Bhagat wrote:

>>>
>>> Please share your opinion on other changes for patch submission as well as resume
>> time.
>>>
>
>>
>> I think more effort should be put into investigating why this happens in the first place.
>> What is the root cause? why doesn't xhci start properly after resume in this case.
>>
> Hello Mathias,
>
> I understand your point and would surely debug the root cause of the issue. But implementing the
> fallback mechanism in SW, if HW does not respond well seems to a better solution to me.
>

Yes, I'll add something like this, at least the xhci parts to make sure the completions are called.

This is not really a fallback, it's just a better burial for xhci. It will be unusable after this.

-Mathias