lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 1 Apr 2016 09:39:38 +0800 From: Shawn Guo <shawnguo@...nel.org> To: Tim Harvey <tharvey@...eworks.com> Cc: Guenter Roeck <linux@...ck-us.net>, Akshay Bhat <akshay.bhat@...esys.com>, Fabio Estevam <festevam@...il.com>, Rob Herring <robh+dt@...nel.org>, Wim Van Sebroeck <wim@...ana.be>, linux-watchdog@...r.kernel.org, Pawel Moll <pawel.moll@....com>, Mark Rutland <mark.rutland@....com>, Ian Campbell <ijc+devicetree@...lion.org.uk>, Kumar Gala <galak@...eaurora.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Sascha Hauer <kernel@...gutronix.de>, Russell King - ARM Linux <linux@....linux.org.uk>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, Justin Waters <justin.waters@...esys.com>, Lucas Stach <l.stach@...gutronix.de>, Stefan Roese <sr@...x.de> Subject: Re: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via 'ext-reset-output' dt prop On Thu, Mar 31, 2016 at 11:01:58AM -0700, Tim Harvey wrote: > On Wed, Mar 30, 2016 at 6:57 PM, Shawn Guo <shawnguo@...nel.org> wrote: > > On Wed, Mar 30, 2016 at 02:09:16PM -0700, Guenter Roeck wrote: > >> The question was if the property name should be ext-reset-output or > >> fsl,ext-reset-output. In my opinion, it should be fsl,ext-reset-output > >> because it is not a generic property. Tim disagrees. > >> > > Guenter, > > My issue regarding the vendor prefix was not a hard dissagreement but > was more about me understanding the rational behind using vendor > prefixes. In this case the imx2_wdt driver 'is' a vendor specific > driver as its compatible strings are prefixed with 'fsl,' so isn't > 'any' property added to devicetree/bindings/watchdog/fsl-imx-wdt.txt > inherently a vendor specific properly already? I assume that is why > the 'big-endian' property isn't 'fsl,big-endian'. We should read it as that 'big-endian' is a generic property defined by generic bindings - bindings/regmap/regmap.txt, and we just reference the bindings in fsl-imx-wdt.txt. Taking mmc bindings as example, bindings/mmc/mmc.txt defines generic bindings, while bindings/mmc/fsl-imx-esdhc.txt defines i.MX vendor specific properties, which should ideally have vendor prefix. Shawn
Powered by blists - more mailing lists