linux-kernel - Re: [PATCH] perf tools: Fix build errors on tsc functions for archs other than x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 1 Apr 2016 16:39:15 +0300
From:	Adrian Hunter <adrian.hunter@...el.com>
To:	Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:	He Kuang <hekuang@...wei.com>, peterz@...radead.org,
	Ingo Molnar <mingo@...nel.org>,
	alexander.shishkin@...ux.intel.com, Jiri Olsa <jolsa@...nel.org>,
	jpoimboe@...hat.com, sukadev@...ux.vnet.ibm.com,
	eranian@...gle.com, wangnan0@...wei.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf tools: Fix build errors on tsc functions for archs
 other than x86

On 01/04/16 16:24, Arnaldo Carvalho de Melo wrote:
> Em Fri, Apr 01, 2016 at 10:13:12AM -0300, Arnaldo Carvalho de Melo escreveu:
>> Em Fri, Apr 01, 2016 at 03:49:32AM +0000, He Kuang escreveu:
>>> Build errors on aarch64:
>>>
>>>   libperf.a(libperf-in.o): In function `convert_timestamp':
>>>   util/jitdump.c:356: undefined reference to `tsc_to_perf_time'
>>>   collect2: error: ld returned 1 exit status
>>>   Makefile.perf:347: recipe for target 'perf' failed
>>>   make[1]: *** [perf] Error 1
>>>   Makefile:68: recipe for target 'all' failed
>>>   make: *** [all] Error 2
>>
>> Got it, my cross-compile environment for aarch64 doesn't build jitdump.c
>> because it needs a package I haven't found in ubuntu:
>>
>> config/Makefile:416: No libcrypto.h found, disables jitted code injection, please install libssl-devel or libssl-dev
>> minimal-ubuntu-x-arm64: Ok
>>
>> BTW, He, what environment do you use to build for arm64, is it a cross
>> compile one? Yocto?
> 
> Adrian, BTW, Ok with this? I'm adding a:
> 
> Fixes: d3e58a3b8b3b ("perf jit: Add support for using TSC as a timestamp")
> 
> And would appreciate your Acked-by.

Sure, already did in http://marc.info/?l=linux-kernel&m=145949505329251

Acked-by: Adrian Hunter <adrian.hunter@...el.com>