linux-kernel - Re: [PATCH v2] module: fix noreturn attribute for __module_put_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 01 Apr 2016 10:24:55 +1030
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Jiri Kosina <jikos@...nel.org>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v2] module: fix noreturn attribute for __module_put_and_exit()

Jiri Kosina <jikos@...nel.org> writes:
> On Mon, 21 Mar 2016, Jiri Kosina wrote:
>
>> __module_put_and_exit() is makred noreturn in module.h declaration, but is
>> lacking the attribute in the definition, which makes some tools (such as
>> sparse) unhappy. Amend the definition with the attribute as well (and
>> reformat the declaration so that it uses more common format).
>> 
>> Signed-off-by: Jiri Kosina <jkosina@...e.cz>
>> ---
>> 
>> v1 -> v2: use __noreturn instead of __attribute__((noreturn)) as requested 
>> 	  by Rusty
>
> Rusty, friendly ping on this one.
>
> Thanks!

Oops, I applied it, and in testing noted that lguest had broken and
ended up getting distracted by that.  I've acked it now (it will
probably wait until next merge window).

Thanks,
Rusty.