linux-kernel - Re: [patch] ipmi_ssif: silence an uninitialized variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 4 Apr 2016 08:03:32 -0500
From:	Corey Minyard <minyard@....org>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	openipmi-developer@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] ipmi_ssif: silence an uninitialized variable warning

On 04/04/2016 06:16 AM, Dan Carpenter wrote:
> My static checker complains that "ret" could be zero here.  (Presumably
> that means the hardware is badly busted).  But the result would be that
> the caller assumes *resp_len is initialized when it's not and it leads
> to a warning.  Let's just silence the warning.

I don't think i2c_smbus_read_block_data() can return a zero, it's either 
an error or a message.

I'm ok with this, but can you add a comment saying why this is here?  I 
don't like strange looking code without explanations.

Thanks,
-corey

> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
>
> diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c
> index 8b3be8b..512c5b6 100644
> --- a/drivers/char/ipmi/ipmi_ssif.c
> +++ b/drivers/char/ipmi/ipmi_ssif.c
> @@ -1232,6 +1232,8 @@ static int do_cmd(struct i2c_client *client, int len, unsigned char *msg,
>   			break;
>   	}
>   
> +	if (ret == 0)
> +		ret = -EINVAL;
>   	if (ret > 0) {
>   		/* Validate that the response is correct. */
>   		if (ret < 3 ||