linux-kernel - Re: [PATCH] usb: dwc3: keystone: drop dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 4 Apr 2016 16:41:22 +0300
From:	Grygorii Strashko <grygorii.strashko@...com>
To:	Felipe Balbi <balbi@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>
CC:	Roger Quadros <rogerq@...com>, <linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <nsekhar@...com>,
	Murali Karicheri <m-karicheri2@...com>
Subject: Re: [PATCH] usb: dwc3: keystone: drop dma_mask configuration

On 04/04/2016 02:45 PM, Felipe Balbi wrote:
>
> Hi,
>
> Grygorii Strashko <grygorii.strashko@...com> writes:
>> The Keystone 2 supports DT-boot only, as result dma_mask will be
>> always configured properly from DT -
>> of_platform_device_create_pdata()->of_dma_configure(). More over,
>> dwc3-keystone.c can be built as module and in this case it's unsafe to
>> assign local variable as dma_mask.
>>
>> Hence, remove dma_mask configuration code.
>>
>> Cc: Murali Karicheri <m-karicheri2@...com>
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>
>
> with these two patches from you, does USB Peripheral work on k2 devices ?

I've tried CONFIG_USB_DWC3_GADGET=y + g_zero and k2e was detected
as gzero dev from Host PC

>
> I'll drop my k2 changes from my series which I sent on saturday.
>

Yes, please.

-- 
regards,
-grygorii