linux-kernel - Re: [PATCH v2 5/5] lib: scatterlist: move SG pool code from SCSI driver to lib/sg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 4 Apr 2016 22:17:01 +0200
From:	Christoph Hellwig <hch@....de>
To:	Ming Lin <mlin@...nel.org>
Cc:	kbuild test robot <lkp@...el.com>, kbuild-all@...org,
	lkml <linux-kernel@...r.kernel.org>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	Christoph Hellwig <hch@....de>
Subject: Re: [PATCH v2 5/5] lib: scatterlist: move SG pool code from SCSI
	driver to lib/sg_pool.c

On Mon, Apr 04, 2016 at 01:15:45PM -0700, Ming Lin wrote:
> cleanup_sdb:
>         for (i = 0; i < SG_MEMPOOL_NR; i++) {
>                 struct sg_pool *sgp = sg_pools + i;
>                 if (sgp->pool)
>                         mempool_destroy(sgp->pool);
>                 if (sgp->slab)
>                         kmem_cache_destroy(sgp->slab);
>         }
> 
> I'll keep the NULL check if no objection.

I don't necessarily, but given that this is a code move I'd prefer
to keep the code as similar as possible in the actual move patch..