linux-kernel - Re: [media 5/6] PCIE bridge driver for PT3 & PX-Q3PE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 Apr 2016 05:48:14 +0800
From:	kbuild test robot <lkp@...el.com>
To:	info@....ma
Cc:	kbuild-all@...org, linux-media@...r.kernel.org,
	Буди Романто, AreMa Inc 
	<knightrider@....ma>, linux-kernel@...r.kernel.org, crope@....fi,
	m.chehab@...sung.com, mchehab@....samsung.com, hdegoede@...hat.com,
	laurent.pinchart@...asonboard.com, mkrufky@...uxtv.org,
	sylvester.nawrocki@...il.com, g.liakhovetski@....de,
	peter.senna@...il.com
Subject: Re: [media 5/6] PCIE bridge driver for PT3 & PX-Q3PE

Hi Буди,

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v4.6-rc2 next-20160404]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/info-are-ma/DVB-driver-for-Earthsoft-PT3-PLEX-PX-Q3PE-ISDB-S-T-PCIE-cards-PX-BCUD-ISDB-S-USB-dongle/20160405-011100
base:   git://linuxtv.org/media_tree.git master
config: s390-allmodconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=s390 

All warnings (new ones prefixed by >>):

   drivers/media/pci/ptx/pxq3pe.c: In function 'pxq3pe_xfr':
>> drivers/media/pci/ptx/pxq3pe.c:257:1: warning: 'pxq3pe_xfr' uses dynamic stack allocation
    }
    ^

vim +/pxq3pe_xfr +257 drivers/media/pci/ptx/pxq3pe.c

   241				regadr	= msg->len ? *msg->buf : 0,
   242				mode	= slvadr == PXQ3PE_I2C_ADR_GPIO	? PXQ3PE_MOD_GPIO
   243					: sz > 1 && i == sz - 2		? PXQ3PE_MOD_STAT
   244					: PXQ3PE_MOD_TUNER;
   245	
   246			mutex_lock(&card->lock);
   247			if (msg->flags & I2C_M_RD) {
   248				u8 buf[sz];
   249	
   250				ret = pxq3pe_r(card, slvadr, regadr, buf, msg->len, mode);
   251				memcpy(msg->buf, buf, msg->len);
   252			} else
   253				ret = pxq3pe_w(card, slvadr, regadr, msg->buf, msg->len, mode);
   254			mutex_unlock(&card->lock);
   255		}
   256		return i;
 > 257	}
   258	
   259	bool pxq3pe_w_gpio2(struct ptx_card *card, u8 dat, u8 mask)
   260	{
   261		u8 val;
   262	
   263		return	pxq3pe_r(card, PXQ3PE_I2C_ADR_GPIO, 0xB, &val, 1, PXQ3PE_MOD_GPIO)	&&
   264			(val = (mask & dat) | (val & ~mask), pxq3pe_w(card, PXQ3PE_I2C_ADR_GPIO, 0xB, &val, 1, PXQ3PE_MOD_GPIO));
   265	}

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (40572 bytes)