linux-kernel - Re: [PATCH char-misc-linus] misc: mic: Fix randconfig build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 5 Apr 2016 02:03:06 -0400
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Sudeep Dutt <sudeep.dutt@...el.com>
Cc:	linux-kernel@...r.kernel.org,
	Ashutosh Dixit <ashutosh.dixit@...el.com>,
	Fengguang Wu <fengguang.wu@...el.com>
Subject: Re: [PATCH char-misc-linus] misc: mic: Fix randconfig build error

On Mon, Apr 04, 2016 at 10:00:23PM -0700, Sudeep Dutt wrote:
> On Mon, 2016-04-04 at 21:41 -0700, Greg Kroah-Hartman wrote:
> > On Mon, Apr 04, 2016 at 09:32:30PM -0700, Sudeep Dutt wrote:
> > > Fixes randconfig build error reported at
> > > https://lkml.org/lkml/2016/4/3/135 by ensuring that
> > > the VOP driver selects VIRTIO.
> > > 
> > > Reported-by: Fengguang Wu <fengguang.wu@...el.com>
> > > Reviewed-by: Ashutosh Dixit <ashutosh.dixit@...el.com>
> > > Signed-off-by: Sudeep Dutt <sudeep.dutt@...el.com>
> > > ---
> > >  drivers/misc/mic/Kconfig | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/drivers/misc/mic/Kconfig b/drivers/misc/mic/Kconfig
> > > index 2e4f3ba..89e5917 100644
> > > --- a/drivers/misc/mic/Kconfig
> > > +++ b/drivers/misc/mic/Kconfig
> > > @@ -132,6 +132,7 @@ config VOP
> > >  	tristate "VOP Driver"
> > >  	depends on 64BIT && PCI && X86 && VOP_BUS
> > >  	select VHOST_RING
> > > +	select VIRTIO
> > 
> > Shouldn't it depend on this instead?
> 
> Hi Greg,
> 
> The documentation for "config VIRTIO" states that "This option is
> selected by any driver which implements the virtio bus". I verified that
> this patch fixes the build for the randconfig which was failing earlier.

Ah, you are right, nevermind, I'll queue this up soon...

thanks,

greg k-h