linux-kernel - RE: [PATCH] usb: dwc3: add debugfs node to dump FIFO/Queue available space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 Apr 2016 11:38:22 +0000
From:	"Du, Changbin" <changbin.du@...el.com>
To:	Greg KH <gregkh@...uxfoundation.org>
CC:	"balbi@...nel.org" <balbi@...nel.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] usb: dwc3: add debugfs node to dump FIFO/Queue
 available space

> > This can be used to check some special issues, like whether data is
> > successfully copied from memory to fifo when a trb is blocked.
> >
> > Signed-off-by: Du, Changbin <changbin.du@...el.com>
> > ---
> >  drivers/usb/dwc3/core.h    |  5 +++++
> >  drivers/usb/dwc3/debugfs.c | 45
> +++++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 50 insertions(+)
> 
> Why did you not include the linux-usb@...r mailing list?
> 
Just forget it :)

> >  static int dwc3_testmode_show(struct seq_file *s, void *unused)
> >  {
> >  	struct dwc3		*dwc = s->private;
> > @@ -648,6 +687,12 @@ int dwc3_debugfs_init(struct dwc3 *dwc)
> >  		goto err1;
> >  	}
> >
> > +	file = debugfs_create_file("fifo", S_IRUGO, root, dwc,
> &dwc3_fifo_fops);
> > +	if (!file) {
> > +		ret = -ENOMEM;
> 
> Um, no, that's not the error here.  You shouldn't care at all about
> debugfs api call results.  Just keep moving on here please.
> 
> thanks,
> 
> greg k-h

Agree with you. I will create another patch to cleanup this piece of code. 
And I found a memory leak issue there, dwc->regset never released. Will also fix it.

Thanks,
Du, Changbin