linux-kernel - [PATCH v1] net: cdc_ncm: update datagram size after changing mtu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed,  6 Apr 2016 13:41:09 +0200
From:	Robert Dobrowolski <robert.dobrowolski@...ux.intel.com>
To:	linux-usb@...r.kernel.org
Cc:	robert.dobrowolski@...ux.intel.com, rafal.f.redzimski@...el.com,
	stable@...r.kernel.org, oliver@...kum.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH v1] net: cdc_ncm: update datagram size after changing mtu

From: Rafal Redzimski <rafal.f.redzimski@...el.com>

Current implementation updates the mtu size and notify cdc_ncm
device using USB_CDC_SET_MAX_DATAGRAM_SIZE request about datagram
size change instead of changing rx_urb_size.

Whenever mtu is being changed, datagram size should also be
updated.

Cc: <stable@...r.kernel.org>
Signed-off-by: Rafal Redzimski <rafal.f.redzimski@...el.com>
Signed-off-by: Robert Dobrowolski <robert.dobrowolski@...ux.intel.com>
---
 drivers/net/usb/cdc_ncm.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
index 2fb31ed..4a47656 100644
--- a/drivers/net/usb/cdc_ncm.c
+++ b/drivers/net/usb/cdc_ncm.c
@@ -746,6 +746,8 @@ int cdc_ncm_change_mtu(struct net_device *net, int new_mtu)
 	if (new_mtu <= 0 || new_mtu > maxmtu)
 		return -EINVAL;
 	net->mtu = new_mtu;
+	cdc_ncm_set_dgram_size(dev, new_mtu);
+
 	return 0;
 }
 EXPORT_SYMBOL_GPL(cdc_ncm_change_mtu);
-- 
1.9.1