linux-kernel - Re: [PATCH v2 09/30] Add tile-specific parity functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 Apr 2016 09:27:33 -0400
From:	Chris Metcalf <cmetcalf@...lanox.com>
To:	<zengzhaoxiu@....com>
CC:	<linux-kernel@...r.kernel.org>,
	Zhaoxiu Zeng <zhaoxiu.zeng@...il.com>
Subject: Re: [PATCH v2 09/30] Add tile-specific parity functions

On 4/6/2016 5:08 AM, zengzhaoxiu@....com wrote:
> From: Zhaoxiu Zeng<zhaoxiu.zeng@...il.com>
>
> Signed-off-by: Zhaoxiu Zeng<zhaoxiu.zeng@...il.com>
> ---
>   arch/tile/include/asm/bitops.h | 26 ++++++++++++++++++++++++++
>   1 file changed, 26 insertions(+)

Since all the code you are adding here is architecture-independent,
I think it would make more sense to have it be in a file like
include/asm-generic/bitops/parity-popcount.h, which can then
be included from arch/tile/include/asm/bitops.h.

-- 
Chris Metcalf, Mellanox Technologies
http://www.mellanox.com